Improve portability, add shared library build, install tlsh_unittest#107
Closed
cgull wants to merge 6 commits into
Closed
Improve portability, add shared library build, install tlsh_unittest#107cgull wants to merge 6 commits into
cgull wants to merge 6 commits into
Conversation
Make it possible to build shared libraries without source edits. Use the major version number on major-version-only solib name. Change make.sh to use the new variable.
This allows us to reuse the name for the tlsh symlink/executable.
Install it too.
Collaborator
|
Thank you - this has been merged as version 4.8.1 I could not just do the pull request |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are for using tlsh on a vendored FreeBSD, using CMake directly, but should improve portability in general.
tlsh_version.h, etc to avoid conflicts with other similarly named files.tlsh_unittest, its ability to generate a hash on a file is generally useful.tlshwith CMake instead ofmake.sh. This helps for environments that use CMake directly.